Integration tests #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Argonus
force-pushed
the
integration-tests
branch
from
ac06d72 to
05835a1
Compare
Argonus
force-pushed
the
integration-tests
branch
16 times, most recently
from
c8921a3 to
3aa8f41
Compare
|
I'm fine with trying this approach. The only concern I can think of is how does one run tests locally? Are there any additional steps? The main thing I'd want is to have at least some amount of testing that can be done locally and to update the readme with instructions |
|
@dantswain It's even easier, and test-containers are handling that :) |
Argonus
force-pushed
the
integration-tests
branch
from
3aa8f41 to
399bb4a
Compare
- Bump kayrock v0.2 - Bump required version to 1.10 - Add tests for 1.15
Add integration tests based on tests containers library. This will allow us to test more complex scenarios than a single docker-compose based ones. s
Argonus
force-pushed
the
integration-tests
branch
from
399bb4a to
ffa47f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Containers
Add
containerbased tests for kafka. Using this approach, we will be able to test more edge-cases scenarios, as in future we are going to add multiple different case support there, likekraftbased apporach, multi nodes apporach and so on and so on.Documentation
Downside
v1.15 elixirversion. That means a little ugly if for test version.Props
Goal
Migrate all
integrationtests & follow ruby-kafka functional tests apporach.